Skip to content

Do not use "default" value of "node_env".#489

Merged
und1sk0 merged 2 commits intomasterfrom
one-last-docker-log-fix
Jun 10, 2016
Merged

Do not use "default" value of "node_env".#489
und1sk0 merged 2 commits intomasterfrom
one-last-docker-log-fix

Conversation

@und1sk0
Copy link
Copy Markdown
Contributor

@und1sk0 und1sk0 commented Jun 3, 2016

  • never run the docker upstart rsyslog config rule if node_env == "default"; for the life of me I cannot figure out where or how node_env gets that value, but we don't want it.

Reviewers

Tests

Test any modifications on one of our environments.

  • tested on epsilon and gamma by @und1sk0 (docks)

Deployment (post-merge)

Ensure that all environments have the given changes.

  • deployed to epsilon
  • deployed to gamma
  • deployed to delta

@und1sk0
Copy link
Copy Markdown
Contributor Author

und1sk0 commented Jun 3, 2016

let's let this soak in pre-prod over the weekend.

@anandkumarpatel
Copy link
Copy Markdown

looks valid
test:

  • ensure deploy of api does not break logs

@und1sk0 und1sk0 merged commit f8d62ff into master Jun 10, 2016
@anandkumarpatel anandkumarpatel deleted the one-last-docker-log-fix branch January 2, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants